Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): simplify scan_range literal casting #3486

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Simplify the auxiliary function introduced in #3470.

The Preferred solution is to do this type alignment in frontend: #3479 #3478

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #3486 (a0aafa1) into main (e37f2b6) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3486   +/-   ##
=======================================
  Coverage   74.42%   74.43%           
=======================================
  Files         769      769           
  Lines      107522   107511   -11     
=======================================
- Hits        80025    80023    -2     
+ Misses      27497    27488    -9     
Flag Coverage Δ
rust 74.43% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/row_seq_scan.rs 16.56% <0.00%> (+1.08%) ⬆️
src/meta/src/manager/id.rs 95.50% <0.00%> (-0.57%) ⬇️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangjinwu xiangjinwu added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 27, 2022
@mergify mergify bot merged commit 217e657 into main Jun 27, 2022
@mergify mergify bot deleted the refactor-3470-pk-cast branch June 27, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants