-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): tag docker image when release #3495
Conversation
What about:
|
Codecov Report
@@ Coverage Diff @@
## main #3495 +/- ##
==========================================
- Coverage 74.41% 74.27% -0.15%
==========================================
Files 768 768
Lines 107793 106619 -1174
==========================================
- Hits 80217 79193 -1024
+ Misses 27576 27426 -150
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
I was going to disable the scheduling of the docker pipeline, and manually trigger the docker pipeline from web, and add docker push in the main pipeline. |
That’s cool! Then we can go with this PR. cc @liurenjie1024 would you please help review PRs for this week? 🥵🤤😋 |
Sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's changed and what's your intention?
Now we will tag 4 things:
git-<sha1>
Now we trigger the "docker.sh" from main pipeline when tag a new version.
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)