Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): tag docker image when release #3495

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Conversation

huangjw806
Copy link
Contributor

@huangjw806 huangjw806 commented Jun 27, 2022

What's changed and what's your intention?

Now we will tag 4 things:

  • latest
  • nightly-date if the BUILD_SOURCE is schedule/ui
  • git tag (e.g. v0.1.9) if there's a tag
  • git hash as git-<sha1>

Now we trigger the "docker.sh" from main pipeline when tag a new version.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@skyzh
Copy link
Contributor

skyzh commented Jun 27, 2022

What about:

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #3495 (10bf4fb) into main (8023c6f) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 10bf4fb differs from pull request most recent head 61f8e1d. Consider uploading reports for the commit 61f8e1d to get more accurate results

@@            Coverage Diff             @@
##             main    #3495      +/-   ##
==========================================
- Coverage   74.41%   74.27%   -0.15%     
==========================================
  Files         768      768              
  Lines      107793   106619    -1174     
==========================================
- Hits        80217    79193    -1024     
+ Misses      27576    27426     -150     
Flag Coverage Δ
rust 74.27% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object_store/src/object/mod.rs 35.71% <0.00%> (-9.75%) ⬇️
...c/frontend/src/optimizer/plan_node/logical_topn.rs 85.60% <0.00%> (-5.61%) ⬇️
src/common/src/types/interval.rs 74.59% <0.00%> (-4.68%) ⬇️
src/frontend/src/utils/condition.rs 93.59% <0.00%> (-2.60%) ⬇️
src/storage/src/hummock/compactor.rs 76.25% <0.00%> (-1.85%) ⬇️
src/storage/src/hummock/compactor_tests.rs 92.40% <0.00%> (-1.70%) ⬇️
src/common/src/array/data_chunk_iter.rs 78.14% <0.00%> (-1.59%) ⬇️
src/frontend/src/catalog/source_catalog.rs 66.66% <0.00%> (-1.52%) ⬇️
src/frontend/src/expr/literal.rs 89.74% <0.00%> (-1.37%) ⬇️
src/frontend/src/handler/handle_privilege.rs 65.97% <0.00%> (-1.36%) ⬇️
... and 72 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@huangjw806
Copy link
Contributor Author

huangjw806 commented Jun 27, 2022

What about:

I was going to disable the scheduling of the docker pipeline, and manually trigger the docker pipeline from web, and add docker push in the main pipeline.

@skyzh
Copy link
Contributor

skyzh commented Jun 27, 2022

That’s cool! Then we can go with this PR. cc @liurenjie1024 would you please help review PRs for this week? 🥵🤤😋

@liurenjie1024
Copy link
Contributor

That’s cool! Then we can go with this PR. cc @liurenjie1024 would you please help review PRs for this week? 🥵🤤😋

Sure

@huangjw806 huangjw806 marked this pull request as draft June 28, 2022 01:55
@huangjw806 huangjw806 marked this pull request as ready for review June 28, 2022 06:45
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huangjw806 huangjw806 enabled auto-merge (squash) June 28, 2022 07:30
@huangjw806 huangjw806 disabled auto-merge June 28, 2022 07:31
@huangjw806 huangjw806 enabled auto-merge (squash) June 28, 2022 07:31
@huangjw806 huangjw806 disabled auto-merge June 28, 2022 07:31
@huangjw806 huangjw806 added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 28, 2022
@mergify mergify bot merged commit 6e793fd into main Jun 28, 2022
@mergify mergify bot deleted the huangjw/release-docker-image branch June 28, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants