Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: risedev: clean code to generate config for legacy frontend #3497

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

fuyufjh
Copy link
Contributor

@fuyufjh fuyufjh commented Jun 27, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Clean useless code

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

None

@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #3497 (ecdc4d4) into main (744f71c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3497      +/-   ##
==========================================
+ Coverage   74.43%   74.45%   +0.01%     
==========================================
  Files         769      768       -1     
  Lines      107554   107532      -22     
==========================================
- Hits        80060    80059       -1     
+ Misses      27494    27473      -21     
Flag Coverage Δ
rust 74.45% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/manager/id.rs 94.94% <0.00%> (-0.57%) ⬇️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit db2cfec into main Jun 27, 2022
@mergify mergify bot deleted the eric/clean_risedev_fe_codegen branch June 27, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants