Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner_test): add logical and optimized plan test for tpch cases #3509

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Jun 28, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

add logical and optimized plan test for tpch cases

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Copy link
Contributor

@likg227 likg227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st1page st1page added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #3509 (9e08610) into main (6e7f1a1) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3509   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files         768      768           
  Lines      107784   107784           
=======================================
+ Hits        80182    80189    +7     
+ Misses      27602    27595    -7     
Flag Coverage Δ
rust 74.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/mock_hummock_meta_client.rs 40.56% <0.00%> (-0.95%) ⬇️
src/meta/src/manager/id.rs 95.50% <0.00%> (-0.57%) ⬇️
src/storage/src/hummock/local_version_manager.rs 79.15% <0.00%> (-0.13%) ⬇️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️
src/frontend/src/expr/utils.rs 99.24% <0.00%> (+0.25%) ⬆️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️
...c/frontend/src/optimizer/plan_node/logical_topn.rs 91.20% <0.00%> (+5.60%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 6a2f4e3 into main Jun 28, 2022
@mergify mergify bot deleted the sts/optimizer_add_more_phase_in_tpch_planner_test branch June 28, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants