refactor(storage): remove arc in shared buffer event sender #3518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title. Our current code use an
Arc
to wrap the shared buffer event sender, which is of typempsc::UnboundedSender
. But it seems that the type supportClone
trait and it implements reference counting internally. Therefore, we don't need theArc
any more and we can clone from the raw sender.Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)