-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): Introducing batch executor micro benchmark framework. #3527
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3527 +/- ##
==========================================
- Coverage 74.49% 74.48% -0.01%
==========================================
Files 771 771
Lines 108209 108216 +7
==========================================
- Hits 80609 80606 -3
- Misses 27600 27610 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. May also enable tikv_jemalloc in bench, so that it will use the same configuration as our cmd.
remove can-merge label for now, feel free to add it back if you want to switch to tikv-jemalloc in next PR. |
fc08f3e
to
1e58819
Compare
Done. It did improve performance when chunk size is small(32, 128), but helps little when chunk size gets larger. |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add FilterExecutor benchmark as an example.
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)