Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): Introducing batch executor micro benchmark framework. #3527

Merged
merged 4 commits into from
Jun 29, 2022

Conversation

liurenjie1024
Copy link
Contributor

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add FilterExecutor benchmark as an example.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@liurenjie1024 liurenjie1024 added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 28, 2022
@liurenjie1024 liurenjie1024 linked an issue Jun 28, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #3527 (b3ca2dc) into main (1ee3dcf) will decrease coverage by 0.00%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##             main    #3527      +/-   ##
==========================================
- Coverage   74.49%   74.48%   -0.01%     
==========================================
  Files         771      771              
  Lines      108209   108216       +7     
==========================================
- Hits        80609    80606       -3     
- Misses      27600    27610      +10     
Flag Coverage Δ
rust 74.48% <8.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/filter.rs 72.44% <0.00%> (-5.58%) ⬇️
src/batch/src/executor/mod.rs 75.80% <ø> (ø)
src/common/src/catalog/schema.rs 84.35% <100.00%> (ø)
src/meta/src/manager/id.rs 95.50% <0.00%> (-1.13%) ⬇️
src/storage/src/hummock/iterator/merge_inner.rs 89.37% <0.00%> (-0.63%) ⬇️
src/frontend/src/expr/utils.rs 98.99% <0.00%> (-0.26%) ⬇️
src/meta/src/rpc/server.rs 80.18% <0.00%> (+0.23%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May also enable tikv_jemalloc in bench, so that it will use the same configuration as our cmd.

@skyzh skyzh removed the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 28, 2022
@skyzh
Copy link
Contributor

skyzh commented Jun 28, 2022

remove can-merge label for now, feel free to add it back if you want to switch to tikv-jemalloc in next PR.

@liurenjie1024 liurenjie1024 added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 29, 2022
@liurenjie1024
Copy link
Contributor Author

remove can-merge label for now, feel free to add it back if you want to switch to tikv-jemalloc in next PR.

Done. It did improve performance when chunk size is small(32, 128), but helps little when chunk size gets larger.

@mergify mergify bot merged commit 89ce3ed into main Jun 29, 2022
@mergify mergify bot deleted the renjie/batch_executor_bench2 branch June 29, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch: Setup benchmark for FilterExecutor.
2 participants