refactor(source): move state related to stream crate #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabVersion <tabvision@bupt.icu>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 884 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 882 | 1 | 1 | 0 |
Click to see the invalid file list
- src/stream/src/executor/source/mod.rs
Signed-off-by: tabVersion <tabvision@bupt.icu>
tabVersion
added
the
mergify/can-merge
Codecov Report
@@ Coverage Diff @@
## main #3545 +/- ##
==========================================
- Coverage 74.44% 74.44% -0.01%
==========================================
Files 771 770 -1
Lines 108464 108424 -40
==========================================
- Hits 80743 80713 -30
+ Misses 27721 27711 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
* fix cycle dep Signed-off-by: tabVersion <tabvision@bupt.icu> * add license Signed-off-by: tabVersion <tabvision@bupt.icu> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tabVersion tabvision@bupt.icu
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
as title, moving because of cycle dependency: risingwave_storage -> risingwave_meta -> risingwave_connector -> risingwave_storage
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)