refactor(streaming): remove dist key for global simple agg & rename to GlobalSimpleAgg
#3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
fuyufjh
reviewed
Jun 29, 2022
| @@ -56,6 +56,7 @@ message MaterializeNode { | |||
| // Local and global aggregator distinguish with each other in PlanNode definition. | |||
| message SimpleAggNode { | |||
| repeated expr.AggCall agg_calls = 1; | |||
| // Not used for global simple agg. | |||
| repeated uint32 distribution_keys = 2; | |||
There was a problem hiding this comment.
SimpleAggNode is also used for local agg. 🤣
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
fuyufjh
approved these changes
Jun 29, 2022
kwannoel
approved these changes
Jun 29, 2022
BowenXiao1999
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
LSTM
BTW can we also change the name from "StreamSimpleAgg" to "StreamGlobalSimpleAgg" in this PR? 😢 https://github.com/singularity-data/risingwave/pull/3320/files
Codecov Report
@@ Coverage Diff @@
## main #3548 +/- ##
=======================================
Coverage 74.44% 74.44%
=======================================
Files 770 770
Lines 108424 108409 -15
=======================================
- Hits 80715 80707 -8
+ Misses 27709 27702 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
xx01cyx
approved these changes
Jun 29, 2022
Cool. |
BugenZhao
changed the title
GlobalSimpleAggExecutorGlobalSimpleAgg
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
force-pushed
the
bz/remove-dist-key-in-global-simple-agg
branch
from
d4dce3f
to
1432209
Compare
BugenZhao
added
the
mergify/can-merge
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
…o `GlobalSimpleAgg` (#3548) * remove dist key for global simple agg Signed-off-by: Bugen Zhao <i@bugenzhao.com> * rename to global Signed-off-by: Bugen Zhao <i@bugenzhao.com> * refine proto doc Signed-off-by: Bugen Zhao <i@bugenzhao.com> * refine comments Signed-off-by: Bugen Zhao <i@bugenzhao.com> * rename frontend plannode Signed-off-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title. We reuse
SimpleAggNodefor both global and local ones, wheredist_keyshould be unused for global simple agg.Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)