Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): make document illustrations prettier #3571

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Conversation

xx01cyx
Copy link
Contributor

@xx01cyx xx01cyx commented Jun 30, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Make document illustrations colorful.
  • Fix some grammar mistakes.

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My part is good, many thanks for your refinements. ❤️

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #3571 (f435e36) into main (9abfc35) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3571   +/-   ##
=======================================
  Coverage   74.38%   74.38%           
=======================================
  Files         771      771           
  Lines      108701   108701           
=======================================
  Hits        80862    80862           
  Misses      27839    27839           
Flag Coverage Δ
rust 74.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
src/meta/src/manager/id.rs 96.06% <0.00%> (+0.56%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liurenjie1024 liurenjie1024 added mergify/can-merge Indicates that the PR can be added to the merge queue labels Jun 30, 2022
@mergify mergify bot merged commit 70cc2f1 into main Jun 30, 2022
@mergify mergify bot deleted the cyx/beautify-doc branch June 30, 2022 09:05
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants