Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): stream hop dist derive #3595

Merged
merged 6 commits into from
Jul 1, 2022
Merged

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Jul 1, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

#3573

@github-actions github-actions bot added the type/fix Bug fix label Jul 1, 2022
@st1page st1page requested a review from TennyZhuang July 1, 2022 07:40
@BugenZhao
Copy link
Member

Could you please enable e2e_test/streaming/time_window.slt.disabled and e2e_test/streaming/time_window_join.slt.disabled and check whether they work?

@@ -52,3 +52,14 @@
StreamExchange { dist: HashShard([0]) }
StreamProject { exprs: [($0 + $1), $0, $2] }
StreamTableScan { table: t, columns: [a, b, _row_id], pk_indices: [2] }
- sql: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also provide logical_plan?

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #3595 (9bf0d6d) into main (c6629e1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3595      +/-   ##
==========================================
- Coverage   74.38%   74.38%   -0.01%     
==========================================
  Files         771      771              
  Lines      109013   109016       +3     
==========================================
+ Hits        81089    81090       +1     
- Misses      27924    27926       +2     
Flag Coverage Δ
rust 74.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/optimizer/plan_node/stream_hop_window.rs 65.00% <100.00%> (+2.83%) ⬆️
src/meta/src/manager/id.rs 95.50% <0.00%> (-0.57%) ⬇️
src/frontend/src/expr/utils.rs 98.74% <0.00%> (-0.26%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #3595 (645f73e) into main (dc115b4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3595   +/-   ##
=======================================
  Coverage   74.37%   74.37%           
=======================================
  Files         771      771           
  Lines      109023   109026    +3     
=======================================
+ Hits        81084    81091    +7     
+ Misses      27939    27935    -4     
Flag Coverage Δ
rust 74.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/optimizer/plan_node/stream_hop_window.rs 65.00% <100.00%> (+2.83%) ⬆️
src/frontend/src/expr/utils.rs 98.74% <0.00%> (-0.51%) ⬇️
src/storage/src/hummock/local_version_manager.rs 81.08% <0.00%> (+0.11%) ⬆️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 41.50% <0.00%> (+0.94%) ⬆️
src/meta/src/manager/id.rs 96.62% <0.00%> (+1.68%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BugenZhao BugenZhao added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 1, 2022
@mergify mergify bot merged commit 6de8f48 into main Jul 1, 2022
@mergify mergify bot deleted the sts/fix_hop_dist_derive branch July 1, 2022 10:49
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
* fix stream hop dist derive

* give more phase for planner test

* re open e2e

* trigger ci

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

Co-authored-by: Bugen Zhao <i@bugenzhao.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
* fix stream hop dist derive

* give more phase for planner test

* re open e2e

* trigger ci

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

Co-authored-by: Bugen Zhao <i@bugenzhao.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants