Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "test: set sortmode rowsort (#3582)" #3600

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jul 1, 2022

This reverts commit d2ec610.

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

See #3583

@xxchan xxchan marked this pull request as ready for review July 1, 2022 10:21
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #3600 (bd331c9) into main (6de8f48) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3600      +/-   ##
==========================================
- Coverage   74.37%   74.37%   -0.01%     
==========================================
  Files         771      771              
  Lines      109026   109026              
==========================================
- Hits        81090    81088       -2     
- Misses      27936    27938       +2     
Flag Coverage Δ
rust 74.37% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/mock_hummock_meta_client.rs 40.56% <0.00%> (-0.95%) ⬇️
src/meta/src/manager/id.rs 95.50% <0.00%> (-0.57%) ⬇️
src/storage/src/hummock/local_version_manager.rs 80.96% <0.00%> (-0.12%) ⬇️
src/frontend/src/expr/utils.rs 99.24% <0.00%> (+0.25%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xxchan xxchan added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 1, 2022
@mergify mergify bot merged commit 5a32e25 into main Jul 1, 2022
@mergify mergify bot deleted the xxchan/guilty-carp branch July 1, 2022 11:26
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
Revert "test: set sortmode rowsort (#3582)"

This reverts commit d2ec610.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…ingwavelabs#3600)

Revert "test: set sortmode rowsort (risingwavelabs#3582)"

This reverts commit d2ec610.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants