-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix parallel sqllogictest on stream e2e #3601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!!!!!!! Both exhausted, QwQ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please help also include the CI script change in #3084, so that parallel e2e test will be running in full cluster mode?
Codecov Report
@@ Coverage Diff @@
## main #3601 +/- ##
==========================================
+ Coverage 74.37% 74.40% +0.02%
==========================================
Files 771 771
Lines 109026 108989 -37
==========================================
Hits 81089 81089
+ Misses 27937 27900 -37
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
* fix: fix parallel sqllogictest on stream e2e * ci update * fix ut Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* fix: fix parallel sqllogictest on stream e2e * ci update * fix ut Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
As title, fixed some bugs when update actors. Finally we can support running streaming e2e test. Big thanks for @MrCroxx 's co-debug!!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
Resolve #3051