Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix parallel sqllogictest on stream e2e #3601

Merged
merged 5 commits into from
Jul 1, 2022

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Jul 1, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

As title, fixed some bugs when update actors. Finally we can support running streaming e2e test. Big thanks for @MrCroxx 's co-debug!!!

./risedev` dev ci-3cn-1fe
sqllogictest -p 4566 -d dev  './e2e_test/streaming/**/*.slt' -j 8

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Add the 'user-facing changes' label if your PR contains changes that are visible to users (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Resolve #3051

@yezizp2012 yezizp2012 requested review from MrCroxx and skyzh July 1, 2022 10:56
@github-actions github-actions bot added the type/fix Bug fix label Jul 1, 2022
@yezizp2012 yezizp2012 requested a review from BugenZhao July 1, 2022 10:56
Copy link
Contributor

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!!!! Both exhausted, QwQ.

src/meta/src/stream/stream_manager.rs Show resolved Hide resolved
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please help also include the CI script change in #3084, so that parallel e2e test will be running in full cluster mode?

src/stream/src/task/mod.rs Show resolved Hide resolved
@yezizp2012 yezizp2012 added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #3601 (fff9e04) into main (5a32e25) will increase coverage by 0.02%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main    #3601      +/-   ##
==========================================
+ Coverage   74.37%   74.40%   +0.02%     
==========================================
  Files         771      771              
  Lines      109026   108989      -37     
==========================================
  Hits        81089    81089              
+ Misses      27937    27900      -37     
Flag Coverage Δ
rust 74.40% <42.85%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/stream/stream_graph.rs 79.16% <ø> (+0.30%) ⬆️
src/stream/src/executor/dispatch.rs 77.11% <ø> (-0.04%) ⬇️
src/stream/src/task/stream_manager.rs 0.00% <0.00%> (ø)
src/stream/src/task/mod.rs 43.90% <66.66%> (+0.15%) ⬆️
src/meta/src/stream/stream_manager.rs 76.88% <100.00%> (ø)
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/meta/src/manager/id.rs 96.06% <0.00%> (ø)
src/frontend/src/expr/utils.rs 98.74% <0.00%> (ø)
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 42.45% <0.00%> (+0.94%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit daede9a into main Jul 1, 2022
@mergify mergify bot deleted the fix/fix-parallel-stream-e2e branch July 1, 2022 11:37
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
* fix: fix parallel sqllogictest on stream e2e

* ci update

* fix ut

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@BugenZhao BugenZhao mentioned this pull request Jul 13, 2022
3 tasks
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
* fix: fix parallel sqllogictest on stream e2e

* ci update

* fix ut

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken pipe error when running parallel sqllogictest
3 participants