Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): integrate sqllogictest with test analysis #3604

Merged
merged 3 commits into from
Jul 2, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jul 2, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Produce junit file with sqllogictest and upload it to Buildkite test analytics
  • Allow parallel e2e test to fail

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #3439

Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh force-pushed the skyzh/junit-sqllogictest- branch from 2c058f2 to 0145df0 Compare July 2, 2022 04:55
@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #3604 (88dfebf) into main (feb7e43) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3604   +/-   ##
=======================================
  Coverage   74.32%   74.33%           
=======================================
  Files         773      773           
  Lines      109358   109358           
=======================================
+ Hits        81284    81289    +5     
+ Misses      28074    28069    -5     
Flag Coverage Δ
rust 74.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
src/storage/src/hummock/local_version_manager.rs 81.08% <0.00%> (+0.11%) ⬆️
src/meta/src/manager/id.rs 96.06% <0.00%> (+0.56%) ⬆️
src/frontend/src/expr/utils.rs 99.24% <0.00%> (+0.75%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 41.50% <0.00%> (+0.94%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh
Copy link
Contributor Author

skyzh commented Jul 2, 2022

Waiting for risinglightdb/sqllogictest-rs#56

@skyzh
Copy link
Contributor Author

skyzh commented Jul 2, 2022

Considering sqllogictest failure is consistently disturbing our development process, let's merge this first before we fix junit of sqllogictest.

@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 2, 2022
@mergify mergify bot merged commit bf7ce03 into main Jul 2, 2022
@mergify mergify bot deleted the skyzh/junit-sqllogictest- branch July 2, 2022 09:50
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
* feat(ci): integrate sqllogictest with test analysis

Signed-off-by: Alex Chi <iskyzh@gmail.com>

* fix docker-compose

Signed-off-by: Alex Chi <iskyzh@gmail.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
)

* feat(ci): integrate sqllogictest with test analysis

Signed-off-by: Alex Chi <iskyzh@gmail.com>

* fix docker-compose

Signed-off-by: Alex Chi <iskyzh@gmail.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: integrate sqllogictest with junit and test analysis
2 participants