Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): bump sqllogictest to v0.5.4 #3611

Merged
merged 5 commits into from
Jul 4, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jul 3, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. If run successfully, we will now see sqllogictest in build kite's test analytics, so as to know which test fails frequently.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #3611 (b77eb23) into main (60234a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3611   +/-   ##
=======================================
  Coverage   74.38%   74.38%           
=======================================
  Files         776      776           
  Lines      110114   110114           
=======================================
  Hits        81905    81905           
  Misses      28209    28209           
Flag Coverage Δ
rust 74.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/manager/id.rs 94.94% <0.00%> (-0.57%) ⬇️
src/frontend/src/expr/utils.rs 98.74% <0.00%> (-0.51%) ⬇️
src/meta/src/barrier/mod.rs 80.08% <0.00%> (+0.20%) ⬆️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️
src/meta/src/model/barrier.rs 90.00% <0.00%> (+3.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh
Copy link
Contributor Author

skyzh commented Jul 3, 2022

/hold

@neverchanje
Copy link
Contributor

@skyzh Do you need approval? What's the problem here?

@skyzh
Copy link
Contributor Author

skyzh commented Jul 4, 2022

Buildkite still cannot recognize sqllogictest's junit file, so I'll work on sqllogictest first.

skyzh added 2 commits July 4, 2022 14:36
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh force-pushed the skyzh/bump-sqllogictest-version branch from 6652d8f to 2360f4c Compare July 4, 2022 06:39
skyzh added 2 commits July 4, 2022 15:45
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2022

Hey @skyzh, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue. More details can be found on the Queue: Embarked in merge train check-run.

@skyzh
Copy link
Contributor Author

skyzh commented Jul 4, 2022

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 722ba98 into main Jul 4, 2022
@mergify mergify bot deleted the skyzh/bump-sqllogictest-version branch July 4, 2022 09:20
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
* chore(ci): bump sqllogictest to v0.5.4

Signed-off-by: Alex Chi <iskyzh@gmail.com>

* bump

Signed-off-by: Alex Chi <iskyzh@gmail.com>

* bump

Signed-off-by: Alex Chi <iskyzh@gmail.com>

* bump

Signed-off-by: Alex Chi <iskyzh@gmail.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants