feat(storage): reduce write lock guard for local_version #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3620 +/- ##
==========================================
- Coverage 74.35% 74.35% -0.01%
==========================================
Files 775 775
Lines 110084 110103 +19
==========================================
+ Hits 81855 81868 +13
- Misses 28229 28235 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
skyzh
approved these changes
Jul 4, 2022
… read ops in the same time
i am not sure it will significantly benefit for this case, so need more bench test, but disucuss with wallace the change of write_lock_guard is expected |
Li0k
added
the
mergify/can-merge
| new_version.set_pinned_version(newly_pinned_version); | ||
| { | ||
| let mut guard = self.local_version.write(); | ||
| *guard = new_version; |
There was a problem hiding this comment.
I'm not sure how is the difference between move one large object and move one Arc pointer.
3 tasks
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
…abs#3620) * feat(storage): reduce write lock guard for local_version * feat(metrics): add metrics for iter_in_process_counts to estimate the read ops in the same time * fix(storage): use rate for metrics iter_in_process_counts Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title ，but we always need more bench for this case
Checklist
[ ] I have written necessary docs and comments[ ] I have added necessary unit tests and integration testsRefer to a related PR or issue link (optional)
local_versionto simple replace #3459