Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: row_id batch acquire #3622

Merged
merged 3 commits into from
Jul 4, 2022
Merged

feat: row_id batch acquire #3622

merged 3 commits into from
Jul 4, 2022

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Jul 4, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

As title.

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Add the 'user-facing changes' label if your PR contains changes that are visible to users (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Resolve #2626

@yezizp2012 yezizp2012 changed the title feat: some optimize for batch row id feat: row_id batch acquire Jul 4, 2022
@yezizp2012 yezizp2012 added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 4, 2022
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this improve the performance a lot?

@yezizp2012
Copy link
Contributor Author

Will this improve the performance a lot?

There must be some I guess. It will reduce some acquiring on current timestamp and some calculation.

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #3622 (5d95449) into main (643ce4a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3622   +/-   ##
=======================================
  Coverage   74.37%   74.38%           
=======================================
  Files         776      776           
  Lines      110096   110114   +18     
=======================================
+ Hits        81883    81906   +23     
+ Misses      28213    28208    -5     
Flag Coverage Δ
rust 74.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/source/src/table_v2.rs 95.87% <ø> (+5.49%) ⬆️
src/batch/src/executor/insert.rs 83.81% <100.00%> (+0.09%) ⬆️
src/source/src/manager.rs 72.72% <100.00%> (-2.03%) ⬇️
src/source/src/row_id.rs 93.10% <100.00%> (+3.44%) ⬆️
src/stream/src/executor/source/source_executor.rs 95.41% <100.00%> (-0.01%) ⬇️
src/meta/src/stream/stream_manager.rs 76.51% <0.00%> (-0.11%) ⬇️
src/frontend/src/expr/utils.rs 99.24% <0.00%> (+0.50%) ⬆️
src/meta/src/manager/id.rs 95.50% <0.00%> (+0.56%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 60234a4 into main Jul 4, 2022
@mergify mergify bot deleted the feat/optimize-batch-row-id branch July 4, 2022 08:54
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
feat: some optimize for batch row id

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source: support batch acquiring row_id
3 participants