fix(optimizer): LogicalAgg::prune_col with duplicate group_keys #3632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
For the following test case:
The proj exprs should be
[$1, $3, $0, $4]
but is actually[$1, $2, $0, $3]
. The output is also wrong:This even panics:
Originally posted by @xiangjinwu in #3533 (comment)
Limitations:
group_keys
as well, and support re-ordering ofgroup_keys
to avoid project completely in the following query:select v2, v3 from t group by v3, v2
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)