Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proto): remove unused messages #3635

Merged
merged 3 commits into from
Jul 4, 2022
Merged

chore(proto): remove unused messages #3635

merged 3 commits into from
Jul 4, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jul 4, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

@xxchan xxchan added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #3635 (fc7ce3f) into main (23a7fae) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3635   +/-   ##
=======================================
  Coverage   74.38%   74.39%           
=======================================
  Files         776      776           
  Lines      110134   110134           
=======================================
+ Hits        81927    81930    +3     
+ Misses      28207    28204    -3     
Flag Coverage Δ
rust 74.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/expr/utils.rs 98.99% <0.00%> (-0.26%) ⬇️
src/storage/src/hummock/local_version_manager.rs 81.49% <0.00%> (+0.11%) ⬆️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️
src/meta/src/manager/id.rs 95.50% <0.00%> (+0.56%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 41.50% <0.00%> (+0.94%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xxchan xxchan requested a review from TennyZhuang July 4, 2022 14:36
@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2022

Hey @xxchan, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue. More details can be found on the Queue: Embarked in merge train check-run.

@xxchan
Copy link
Member Author

xxchan commented Jul 4, 2022

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit ab28ce1 into main Jul 4, 2022
@mergify mergify bot deleted the xxchan/excellent-deer branch July 4, 2022 15:59
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants