Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risectl): list tables and scan by id #3647

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jul 5, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Support two more commands:

./risedev ctl table scan-by-id 1002
./risedev ctl table list

Note that internal state table is not in catalog, and could not be scanned for now.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

related to #3609

Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #3647 (92b00b1) into main (606a956) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3647      +/-   ##
==========================================
- Coverage   74.41%   74.38%   -0.03%     
==========================================
  Files         780      781       +1     
  Lines      110645   110682      +37     
==========================================
+ Hits        82332    82334       +2     
- Misses      28313    28348      +35     
Flag Coverage Δ
rust 74.38% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ctl/src/cmd_impl/table/list.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/table/scan.rs 0.00% <0.00%> (ø)
src/ctl/src/lib.rs 2.08% <0.00%> (-0.30%) ⬇️
src/meta/src/rpc/service/ddl_service.rs 3.48% <0.00%> (ø)
src/rpc_client/src/meta_client.rs 0.00% <0.00%> (ø)
src/frontend/src/expr/utils.rs 98.74% <0.00%> (-0.51%) ⬇️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/meta/src/stream/stream_manager.rs 76.61% <0.00%> (+0.10%) ⬆️
src/storage/src/hummock/local_version_manager.rs 81.49% <0.00%> (+0.11%) ⬆️
src/meta/src/hummock/compaction_group/manager.rs 90.09% <0.00%> (+0.23%) ⬆️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 5, 2022
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit ce7612d into main Jul 5, 2022
@mergify mergify bot deleted the skyzh/table-scan-risectl branch July 5, 2022 07:02
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
* feat(risectl): list tables and scan by id

Signed-off-by: Alex Chi <iskyzh@gmail.com>

* fix proto check

Signed-off-by: Alex Chi <iskyzh@gmail.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants