Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix env variables in docker push step #3653

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

huangjw806
Copy link
Contributor

@huangjw806 huangjw806 commented Jul 5, 2022

What's changed and what's your intention?

As the title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@github-actions github-actions bot added the type/fix Bug fix label Jul 5, 2022
@huangjw806 huangjw806 requested a review from skyzh July 5, 2022 07:50
@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #3653 (d33aca7) into main (480010f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3653   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files         781      781           
  Lines      110788   110788           
=======================================
  Hits        82431    82431           
  Misses      28357    28357           
Flag Coverage Δ
rust 74.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/expr/utils.rs 98.99% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 2df3440 into main Jul 5, 2022
@mergify mergify bot deleted the huangjw/fix-ci-docker-push branch July 5, 2022 08:12
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants