Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support maxwell format #6057

Merged
merged 5 commits into from Oct 27, 2022
Merged

feat: support maxwell format #6057

merged 5 commits into from Oct 27, 2022

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Oct 26, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

as title

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Connector (sources & sinks)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

allow create source with maxwell format. Maxwell is still a CDC format, pk is required.

create materialized source s8 (
  id integer,
  first_name varchar,
  last_name varchar,
  email varchar,
  PRIMARY KEY (id)
) with (
  connector = 'kafka',
  topic = 'xxxx',
  properties.bootstrap.server = '127.0.0.1:29092'
) row format maxwell

Refer to a related PR or issue link (optional)

resolve #6044

Signed-off-by: tabVersion <tabvision@bupt.icu>
Signed-off-by: tabVersion <tabvision@bupt.icu>
Signed-off-by: tabVersion <tabvision@bupt.icu>
@tabVersion tabVersion added the user-facing-changes Contains changes that are visible to users label Oct 26, 2022
Signed-off-by: tabVersion <tabvision@bupt.icu>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #6057 (d325f4a) into main (23ca731) will decrease coverage by 0.05%.
The diff coverage is 25.37%.

@@            Coverage Diff             @@
##             main    #6057      +/-   ##
==========================================
- Coverage   74.63%   74.58%   -0.06%     
==========================================
  Files         930      931       +1     
  Lines      148422   148518      +96     
==========================================
- Hits       110772   110767       -5     
- Misses      37650    37751     +101     
Flag Coverage Δ
rust 74.58% <25.37%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/create_source.rs 77.27% <0.00%> (-4.39%) ⬇️
src/source/src/lib.rs 90.00% <ø> (ø)
src/source/src/manager.rs 79.03% <0.00%> (-0.26%) ⬇️
src/source/src/parser/mod.rs 81.02% <0.00%> (-1.21%) ⬇️
src/sqlparser/src/ast/statement.rs 77.60% <0.00%> (-0.73%) ⬇️
src/sqlparser/src/keywords.rs 100.00% <ø> (ø)
src/stream/src/executor/barrier_align.rs 98.63% <ø> (-1.37%) ⬇️
src/stream/src/executor/chain.rs 89.88% <ø> (ø)
src/stream/src/executor/dispatch.rs 72.50% <0.00%> (-0.10%) ⬇️
src/stream/src/executor/global_simple_agg.rs 95.55% <ø> (ø)
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@waruto210 waruto210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

@tabVersion
Copy link
Contributor Author

merge first, will add more tests later

@tabVersion tabVersion added the mergify/can-merge Indicates that the PR can be added to the merge queue label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connector: support format maxwell-json
2 participants