fix: enable async stack trace by default #6539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Codecov Report
@@ Coverage Diff @@
## main #6539 +/- ##
==========================================
+ Coverage 74.01% 74.06% +0.04%
==========================================
Files 983 989 +6
Lines 160712 161778 +1066
==========================================
+ Hits 118952 119820 +868
- Misses 41760 41958 +198
Flags with carried forward coverage won't be shown. Click here to find out more.
馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
commented
Nov 23, 2022
Comment on lines
-246
to
-247
| /// With `debug_assertions` on, this span will be disabled statically to avoid affecting | ||
| /// performance too much. Therefore, `verbose` mode in [`TraceConfig`] is ignored. |
There was a problem hiding this comment.
Previously I thought the bad performance with verbose span, non-verbose configuration, and debug profile was caused by the extra code of matching the thread-local context. But actually, I just forgot to pass the config to the trace root and always use verbose: true configuration, as above. 馃ぃ
HuaHuaY
approved these changes
Nov 23, 2022
BugenZhao
added
the
mergify/can-merge
lmatz
pushed a commit
that referenced
this pull request
Nov 28, 2022
* fix config Signed-off-by: Bugen Zhao <i@bugenzhao.com> * turn on trace by default Signed-off-by: Bugen Zhao <i@bugenzhao.com> * try use default verbose in CI Signed-off-by: Bugen Zhao <i@bugenzhao.com> * cleanup comments Signed-off-by: Bugen Zhao <i@bugenzhao.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
lmatz
added a commit
that referenced
this pull request
Nov 28, 2022
fix: enable async stack trace by default (#6539) * fix config Signed-off-by: Bugen Zhao <i@bugenzhao.com> * turn on trace by default Signed-off-by: Bugen Zhao <i@bugenzhao.com> * try use default verbose in CI Signed-off-by: Bugen Zhao <i@bugenzhao.com> * cleanup comments Signed-off-by: Bugen Zhao <i@bugenzhao.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously the async stack trace is only enabled by default only if the user launches with
risedev. This PR also enables it by default if no arg is specified, which is for production (cloud) deployment.I've benched the release build with async stack trace = (verbose, on, off) and hardly found any performance regression. So I guess we're okay to enable it in production.
I'd also like to cherry pick this fix to the release branch. 馃
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)