Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(sink): change the link to download spark to archive link #8036

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Feb 20, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Copy link
Contributor

@jon-chuang jon-chuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #8036 (97dfe7d) into main (d8198fa) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8036      +/-   ##
==========================================
- Coverage   71.35%   71.34%   -0.01%     
==========================================
  Files        1121     1121              
  Lines      180839   180839              
==========================================
- Hits       129034   129028       -6     
- Misses      51805    51811       +6     
Flag Coverage Δ
rust 71.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object_store/src/object/mem.rs 86.48% <0.00%> (-0.78%) ⬇️
src/storage/src/hummock/sstable_store.rs 65.00% <0.00%> (-0.32%) ⬇️
src/storage/src/hummock/compactor/iterator.rs 97.95% <0.00%> (-0.30%) ⬇️
src/object_store/src/object/mod.rs 50.31% <0.00%> (-0.22%) ⬇️
src/common/src/types/ordered_float.rs 30.87% <0.00%> (-0.20%) ⬇️
src/stream/src/executor/aggregation/minput.rs 96.25% <0.00%> (-0.11%) ⬇️
src/common/src/cache.rs 97.26% <0.00%> (+0.10%) ⬆️
src/storage/src/hummock/sstable/multi_builder.rs 97.69% <0.00%> (+0.32%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wenym1 wenym1 added the mergify/can-merge Indicates that the PR can be added to the merge queue label Feb 20, 2023
@mergify mergify bot merged commit 40da822 into main Feb 20, 2023
@mergify mergify bot deleted the yiming/ci-spark-link branch February 20, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ci mergify/can-merge Indicates that the PR can be added to the merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants