Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(function): alias array_to_string to array_join #8069

Merged
merged 3 commits into from Feb 21, 2023
Merged

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Feb 21, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As per the title, the name array_join is widely used by databricks, presto, clickhouse, starrocks and firebolt, etc.

Checklist

- [ ] I have written necessary rustdoc comments

  • I have added necessary unit tests and integration tests
    - [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
    - [ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

array_join is alias to array_to_string.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #8069 (a896eda) into main (96e852c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8069      +/-   ##
==========================================
- Coverage   71.33%   71.33%   -0.01%     
==========================================
  Files        1129     1129              
  Lines      181501   181502       +1     
==========================================
- Hits       129477   129471       -6     
- Misses      52024    52031       +7     
Flag Coverage Δ
rust 71.33% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/binder/expr/function.rs 89.30% <100.00%> (+0.01%) ⬆️
src/object_store/src/object/mem.rs 86.48% <0.00%> (-0.78%) ⬇️
...torage/src/hummock/local_version/pinned_version.rs 88.75% <0.00%> (-0.63%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 65.46% <0.00%> (-0.52%) ⬇️
src/storage/src/hummock/sstable_store.rs 64.62% <0.00%> (-0.32%) ⬇️
src/storage/src/hummock/compactor/iterator.rs 97.95% <0.00%> (-0.30%) ⬇️
src/object_store/src/object/mod.rs 48.65% <0.00%> (-0.21%) ⬇️
src/storage/src/hummock/compactor/mod.rs 80.69% <0.00%> (-0.20%) ⬇️
src/common/src/cache.rs 97.15% <0.00%> (-0.11%) ⬇️
src/common/src/types/ordered_float.rs 31.06% <0.00%> (+0.19%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lmatz lmatz added the user-facing-changes Contains changes that are visible to users label Feb 21, 2023
@lmatz lmatz added the mergify/can-merge Indicates that the PR can be added to the merge queue label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants