Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: telemetry #8670

Merged
merged 61 commits into from
Mar 24, 2023
Merged

feat: telemetry #8670

merged 61 commits into from
Mar 24, 2023

Conversation

odysa
Copy link
Contributor

@odysa odysa commented Mar 21, 2023

No description provided.

odysa and others added 17 commits March 14, 2023 14:03
Co-authored-by: Yuhao Su <31772373+yuhao-su@users.noreply.github.com>
Co-authored-by: Dylan <chenzl25@mail2.sysu.edu.cn>
Co-authored-by: Yuanxin Cao <60498509+xx01cyx@users.noreply.github.com>
Co-authored-by: ZENOTME <43447882+ZENOTME@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: congyi wang <58715567+wcy-fdu@users.noreply.github.com>
@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2023

⚠️ The sha of the head commit of this PR conflicts with #7384. Mergify cannot evaluate rules on this PR. ⚠️

@hzxa21
Copy link
Collaborator

hzxa21 commented Mar 21, 2023

cc @lmatz Can we merge this PR onto v0.18.0-rc so that we can have telemetry enabled starting from this release?

@wenym1
Copy link
Contributor

wenym1 commented Mar 21, 2023

The number of line changes is different to in #7384.

Seems that we have included some code in main that is after v0.18.0-rc.

@wenym1 wenym1 requested a review from lmatz March 23, 2023 07:19
@lmatz
Copy link
Contributor

lmatz commented Mar 23, 2023

Could you remove the unused import

warning: unused import: `uuid::Uuid`
  --> src/meta/src/rpc/service/telemetry_service.rs:22:5
   |
22 | use uuid::Uuid;

and we are good to go

I tried to push the changes but found the PR comes from your forked repo

@lmatz lmatz merged commit cbd3403 into risingwavelabs:v0.18.0-rc Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants