Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(common): Optimize null_bitmap with
Set64
#8941perf(common): Optimize null_bitmap with
Set64
#8941Changes from 24 commits
780f559
eb3b6c9
3dc8b20
95dabcb
1172cc6
97a5ffe
adb9d63
e960edb
8ddf959
9de2ed2
351a9bd
bf7a623
f750b08
fd1f966
afce304
55fd198
5ab3953
05919c0
f4b8799
e9adce6
127cfb6
340afe5
d6121fe
ce3fcc7
1568e0a
07e20f7
a4b54c6
a9abe56
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether this can cover all cases. For example, the columns in
OVER (PARTITION BY <cols>)
may also be used as a group key.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With workaround listed below, I think we can remove this, since no more max group keys.
This comment was marked as resolved.
Sorry, something went wrong.