Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate handling for sum aggregation function of Int256. #9191

Merged
merged 7 commits into from
Apr 14, 2023

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Apr 14, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR implements a separate, rough sum function for non-primitive types such as Int256. This should be considered and removed during future refactoring of the aggregation functions.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
    - [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

@github-actions github-actions bot added type/feature user-facing-changes Contains changes that are visible to users labels Apr 14, 2023
@shanicky shanicky requested a review from lmatz April 14, 2023 08:33
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #9191 (d481982) into main (77aacbd) will increase coverage by 0.00%.
The diff coverage is 86.27%.

@@           Coverage Diff            @@
##             main    #9191    +/-   ##
========================================
  Coverage   70.82%   70.82%            
========================================
  Files        1200     1201     +1     
  Lines      200261   200363   +102     
========================================
+ Hits       141829   141902    +73     
- Misses      58432    58461    +29     
Flag Coverage Δ
rust 70.82% <86.27%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/sig/agg.rs 19.04% <0.00%> (-0.19%) ⬇️
src/expr/src/vector_op/agg/aggregator.rs 55.13% <66.66%> (+0.19%) ⬆️
src/expr/src/vector_op/agg/non_primitive_sum.rs 87.75% <87.75%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanicky shanicky added this pull request to the merge queue Apr 14, 2023
Merged via the queue into main with commit b076e88 Apr 14, 2023
@shanicky shanicky deleted the peng/num256-agg-sum branch April 14, 2023 10:50
@hengm3467 hengm3467 added the 📖✓ Covered or will be covered in the user docs. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants