Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expr): support multibyte Unicode for overlay and ascii #9321

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fixes #9118

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Types of user-facing changes

  • SQL commands, functions, and operators

Release note

Support multibyte Unicode for overlay and ascii.

@github-actions github-actions bot added type/fix Bug fix user-facing-changes Contains changes that are visible to users labels Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #9321 (24dc46b) into main (8052dec) will increase coverage by 0.00%.
The diff coverage is 84.61%.

@@           Coverage Diff           @@
##             main    #9321   +/-   ##
=======================================
  Coverage   70.81%   70.81%           
=======================================
  Files        1219     1219           
  Lines      202512   202519    +7     
=======================================
+ Hits       143400   143416   +16     
+ Misses      59112    59103    -9     
Flag Coverage Δ
rust 70.81% <84.61%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/vector_op/overlay.rs 93.84% <83.33%> (-6.16%) ⬇️
src/expr/src/vector_op/ascii.rs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: correctly handle unicode characters for string functions
3 participants