Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle user as staff #3

Merged
merged 2 commits into from
Mar 4, 2016
Merged

Handle user as staff #3

merged 2 commits into from
Mar 4, 2016

Conversation

andotri
Copy link
Contributor

@andotri andotri commented Mar 4, 2016

Example of arrays:

Array
(
[ldap_cn] => TRIANDO
[kd_org] => 06.00.12.01
[peran_user] => mahasiswa
[nama] => Triando
[npm] => 1206237265
)

Array
(
[ldap_cn] => Ervira Rusdhiana
[peran_user] => staff
[nip] => 091525019
[nama] => Ervira Rusdhiana
)

Example of arrays:

Array
(
[ldap_cn] => TRIANDO
[kd_org] => 06.00.12.01
[peran_user] => mahasiswa
[nama] => Triando
[npm] => 1206237265
)

Array
(
[ldap_cn] => Ervira Rusdhiana
[peran_user] => staff
[nip] => 091525019
[nama] => Ervira Rusdhiana
)
@bobbypriam
Copy link
Contributor

Thanks, @andotri! Sebelumnya belum ada kebutuhan staff dan tidak ada akun staff untuk uji coba juga. Kalau boleh bisa tolong update juga example.php untuk merefleksikan perubahannya?

Other than that, LGTM.

@bobbypriam
Copy link
Contributor

Oh, and please change == to === on every comparisons. Coercions are nasty, we should avoid them. Some reasons.

@jundialwan
Copy link
Contributor

Wah, menarik.
Sepertinya akan membantu dikala propensi terkait sistem-sistem staff di UI :)

And agree.. === is better B)

@andotri
Copy link
Contributor Author

andotri commented Mar 4, 2016

Okee, sepertinya untuk kedepan butuh eksperimen ke:

  • staf tetap
  • dosen tetap
  • dosen tidak tetap

cc: teman-teman yang akan menggunakan sso dengan staf dan dosen ui hahaha

@bobbypriam
Copy link
Contributor

Nice! Merging the changes.

bobbypriam added a commit that referenced this pull request Mar 4, 2016
Handle user with role "staff"
@bobbypriam bobbypriam merged commit 7b34b2b into ristekoss:master Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants