Fix JsonSerializationException when missing database feature #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix JsonSerializationException that occurs when feature is added to the database and later removed from the application. A further enhancement could be cleaning up the database to avoid these exceptions happening over and over but I'll leave that for the future. This should get us working for now.
kendaleiv
force-pushed
the
fix-missing-feature
branch
from
341f6c6
to
dd93c93
Compare
kendaleiv
added a commit
to kendaleiv/RimDev.FeatureFlags
that referenced
this pull request
Oct 14, 2019
Better fix for ritterim#36 that prevents an exception from occurring, rather than catching it after the fact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JsonSerializationException that occurs when feature is added to
the database and later removed from the application.
A further enhancement could be cleaning up the database to avoid
these exceptions happening over and over but I'll leave that for the
future. This should get us working for now.