naming consistency

ritwickdey · May 17, 2018 · 4f5d293 · 4f5d293
1 parent 50b8d6d
commit 4f5d293
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/background.js b/background.js
@@ -2,7 +2,7 @@
 
     'use strict';
 
-    const SETUP_STRING = 'live-reload-extension-new-setup';
+    const SETUP_STRING = 'live-reload-extension-new-setup-v2';
 
     function sendMsgToAllContainPage(req, data) {
         chrome.tabs.query({}, tabs => {

diff --git a/popup/popup.html b/popup/popup.html
@@ -28,8 +28,8 @@
 
         <div class="row">
             <div>
-                <input type="checkbox" id="proxyCheckBox">
-                <label for="proxyCheckBox">I don't want proxy setup</label>
+                <input type="checkbox" id="noProxyCheckBox">
+                <label for="noProxyCheckBox">I don't want proxy setup</label>
             </div>
         </div>
 

diff --git a/popup/popup.js b/popup/popup.js
@@ -3,7 +3,7 @@
     'use strict';
 
     const liveReloadCheck = document.getElementById('liveReloadCheck');
-    const proxyCheckBox = document.getElementById('proxyCheckBox');
+    const noProxyCheckBox = document.getElementById('noProxyCheckBox');
     const actualServerAddress = document.getElementById('actualServer');
     const liveServerAddress = document.getElementById('liveServer');
     const submitBtn = document.getElementById('submitBtn');
@@ -13,7 +13,7 @@
     function submitForm() {
         const formData = {
             isEnable: liveReloadCheck.checked,
-            proxySetup: proxyCheckBox.checked,
+            proxySetup: !noProxyCheckBox.checked,
             actualUrl: actualServerAddress.value || '',
             liveServerUrl: liveServerAddress.value || ''
         }
@@ -27,23 +27,24 @@
     liveReloadCheck.onclick = () => {
         submitForm();
     }
-    proxyCheckBox.onchange = () => {
+    noProxyCheckBox.onchange = () => {
         submitForm();
     }
 
-    proxyCheckBox.onclick = () => {
-        serverSetupDiv.className = proxyCheckBox.checked ? 'show' : 'hide';
+    noProxyCheckBox.onclick = () => {
+        serverSetupDiv.className = noProxyCheckBox.checked ? 'show' : 'hide';
     }
 
     document.addEventListener('DOMContentLoaded', () => {
         chrome.runtime.sendMessage({
             req: 'get-live-server-config'
         }, (data) => {
+            console.log('popupwidnow')
             liveReloadCheck.checked = data.isEnable || false;
-            proxyCheckBox.checked = data.proxySetup || false;
+            noProxyCheckBox.checked = data.proxySetup || false;
             actualServerAddress.value = data.actualUrl || '';
             liveServerAddress.value = data.liveServerUrl || '';
-            serverSetupDiv.className =  proxyCheckBox.checked ? 'show' : 'hide';
+            serverSetupDiv.className =  noProxyCheckBox.checked ? 'show' : 'hide';
         });
     });