- Windows compatibility for import
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
changed the title
modulefile:// to import URLs for Windows compatibility
- Avoid need for running `prebuild` (which apparently auto-occurs during install given that [`build`](https://docs.npmjs.com/cli/build) does. `prebuild` wouldn't be run with `npm i --ignore-scripts` anyways. - Change `prepublishOnly` to `prepare` to ensure local `npm install` (as from a Git clone) gets the `dist` files built
brettz9
changed the title
file:// to import URLs for Windows compatibilityimport
|
@ritz078 : Per #71 (comment) , this should now be ready for review, as the approach has been confirmed to work. |
ritz078
approved these changes
May 2, 2020
|
Thanks a lot for this fix @brettz9 |
|
released in v8.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71.
importprebuild(which apparently auto-occurs during install given thatbuilddoes.prebuildwouldn't be run withnpm i --ignore-scriptsanyways.prepublishOnlytoprepareto ensure localnpm install(as from a Git clone) gets thedistfiles built