Add subscription events that are emitted when a queue is paused or resumed #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sumed Here, largely as a potential way to resolve #324, add new events `EventKindQueuePaused` and `EventKindQueueResumed` which are emitted whenever a queue is paused or resumed. Tests will be able to use these to wait on the completion of these actions even if calls to `QueuePause` or `QueueResume` are asynchronous (as they are currently), or if the pause/resume was initiated by a different client. I expect them to also be useful for general telemetry/logging purposes. Recall that when we first designed the subscription API, we explicitly _did not_ add a way to subscribe to all possible event types. This means that although the new queue events fill `Event.Queue` instead of `Event.Job` and `Event.JobStats`, the API is still forward compatible because nobody could be listening to these yet.
|
@bgentry Wrote this on the airplane before seeing you'd done it already. Opening PR for posterity. |
|
Should be superseded by the updated #327. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, largely as a potential way to resolve #324, add new events
EventKindQueuePausedandEventKindQueueResumedwhich are emittedwhenever a queue is paused or resumed. Tests will be able to use these
to wait on the completion of these actions even if calls to
QueuePauseor
QueueResumeare asynchronous (as they are currently), or if thepause/resume was initiated by a different client. I expect them to also
be useful for general telemetry/logging purposes.
Recall that when we first designed the subscription API, we explicitly
did not add a way to subscribe to all possible event types. This means
that although the new queue events fill
Event.Queueinstead ofEvent.JobandEvent.JobStats, the API is still forward compatiblebecause nobody could be listening to these yet.