-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add service tokens #636
Conversation
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
ca65811
to
2b0f7e4
Compare
2b0f7e4
to
8da0d66
Compare
a0b8538
to
89c1666
Compare
1fdc448
to
e66ae58
Compare
89c1666
to
e185ca9
Compare
e66ae58
to
0253f00
Compare
e185ca9
to
5d8b4ce
Compare
3c57734
to
e768e8f
Compare
5d8b4ce
to
214bf51
Compare
e768e8f
to
03f6476
Compare
214bf51
to
c1bce3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote my own docs for this in the script file parallel to this being written:
# To install fern, first clone the repo and check out the branch
# $ git clone https://github.com/rivet-gg/fern
# $ cd fern
# $ git checkout max/remove-headers
#
# Then, follow the instructions in SETUP.md and CONTRIBUTING.md to compile fern
# $ yarn
# $ yarn compile
# $ yarn dist:cli:dev
#
# Finally, run this with the path to the fern repo, say:
# $ FERN_REPO_PATH=~/fern ./oss/scripts/fern/gen.sh
I think we can remove mine, it makes more sense to go here. I'm going to make some other requests for things that could be a bit better in the writeup based on mine.
## Step 1: Cloud & build Fern | ||
|
||
```sh | ||
gh repo clone rivet-gg/fern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead use git
here? I think people will be less familiar with gh
, and potentially not know what the command would do.
gh repo clone rivet-gg/fern | |
git clone https://github.com/rivet-gg/fern |
yarn install | ||
yarn husky install | ||
yarn dist:cli:dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have yarn compile
right before yarn dist:cli:dev
, is it needed?
## Step 1: Cloud & build Fern | ||
|
||
```sh | ||
gh repo clone rivet-gg/fern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my version, I said to check out max/remove-headers
. Is that now included in trunk?
03f6476
to
eb1a6cf
Compare
c1bce3d
to
cbca7d6
Compare
Closing in favor of OpenGB |
Fixes RVT-3700
Fixes RVT-3702