Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add service tokens #636

Closed
wants to merge 1 commit into from
Closed

Conversation

NathanFlurry
Copy link
Member

Fixes RVT-3700
Fixes RVT-3702

Copy link

linear bot commented Apr 5, 2024

Copy link
Contributor

graphite-app bot commented Apr 5, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@NathanFlurry NathanFlurry force-pushed the 04-05-feat_add_service_tokens branch from ca65811 to 2b0f7e4 Compare April 5, 2024 05:44
@NathanFlurry NathanFlurry changed the base branch from main to 04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt April 11, 2024 22:52
@NathanFlurry NathanFlurry force-pushed the 04-05-feat_add_service_tokens branch 2 times, most recently from a0b8538 to 89c1666 Compare April 12, 2024 01:34
@NathanFlurry NathanFlurry force-pushed the 04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt branch from 1fdc448 to e66ae58 Compare April 12, 2024 06:04
@NathanFlurry NathanFlurry force-pushed the 04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt branch from e66ae58 to 0253f00 Compare April 12, 2024 06:09
@NathanFlurry NathanFlurry changed the base branch from 04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt to 04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container April 12, 2024 06:09
@NathanFlurry NathanFlurry force-pushed the 04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container branch from 3c57734 to e768e8f Compare April 12, 2024 06:44
@NathanFlurry NathanFlurry force-pushed the 04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container branch from e768e8f to 03f6476 Compare April 12, 2024 21:21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote my own docs for this in the script file parallel to this being written:

# To install fern, first clone the repo and check out the branch
# $ git clone https://github.com/rivet-gg/fern
# $ cd fern
# $ git checkout max/remove-headers
#
# Then, follow the instructions in SETUP.md and CONTRIBUTING.md to compile fern
# $ yarn
# $ yarn compile
# $ yarn dist:cli:dev
#
# Finally, run this with the path to the fern repo, say:
# $ FERN_REPO_PATH=~/fern ./oss/scripts/fern/gen.sh

I think we can remove mine, it makes more sense to go here. I'm going to make some other requests for things that could be a bit better in the writeup based on mine.

## Step 1: Cloud & build Fern

```sh
gh repo clone rivet-gg/fern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead use git here? I think people will be less familiar with gh, and potentially not know what the command would do.

Suggested change
gh repo clone rivet-gg/fern
git clone https://github.com/rivet-gg/fern

Comment on lines +8 to +10
yarn install
yarn husky install
yarn dist:cli:dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have yarn compile right before yarn dist:cli:dev, is it needed?

## Step 1: Cloud & build Fern

```sh
gh repo clone rivet-gg/fern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my version, I said to check out max/remove-headers. Is that now included in trunk?

@NathanFlurry NathanFlurry force-pushed the 04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container branch from 03f6476 to eb1a6cf Compare April 15, 2024 21:18
@NathanFlurry NathanFlurry changed the base branch from 04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container to main April 15, 2024 21:23
@NathanFlurry
Copy link
Member Author

Closing in favor of OpenGB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants