Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace auto-generate public ip with 127.0.0.1 #650

Merged

Conversation

NathanFlurry
Copy link
Member

Motivation

Most people test the OSS repo locally. By defaulting to the public IP, the Terraform cluster fails to finish booting because it can't be accessed.

We'll provide better docs on the config after our OSS refresh.

Copy link
Contributor

graphite-app bot commented Apr 11, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@NathanFlurry NathanFlurry force-pushed the 04-10-fix_remove_erronious_dep_on_linode_cloudflare_tokens branch from 9d41077 to 37b2307 Compare April 11, 2024 21:40
@NathanFlurry NathanFlurry force-pushed the 04-10-chore_replace_auto-generate_public_ip_with_127.0.0.1 branch from e50c2b2 to 274ae10 Compare April 11, 2024 21:40
@NathanFlurry NathanFlurry force-pushed the 04-10-fix_remove_erronious_dep_on_linode_cloudflare_tokens branch from 37b2307 to 1b0cdee Compare April 11, 2024 21:57
@NathanFlurry NathanFlurry force-pushed the 04-10-chore_replace_auto-generate_public_ip_with_127.0.0.1 branch from 274ae10 to 9f8bc98 Compare April 11, 2024 21:57
@NathanFlurry NathanFlurry force-pushed the 04-10-fix_remove_erronious_dep_on_linode_cloudflare_tokens branch from 1b0cdee to 9250559 Compare April 11, 2024 21:59
@NathanFlurry NathanFlurry force-pushed the 04-10-chore_replace_auto-generate_public_ip_with_127.0.0.1 branch from 9f8bc98 to 1c9229e Compare April 11, 2024 21:59
Copy link
Contributor

graphite-app bot commented Apr 12, 2024

Merge activity

@NathanFlurry NathanFlurry force-pushed the 04-10-fix_remove_erronious_dep_on_linode_cloudflare_tokens branch from 9250559 to 2e57e30 Compare April 12, 2024 06:03
@NathanFlurry NathanFlurry force-pushed the 04-10-chore_replace_auto-generate_public_ip_with_127.0.0.1 branch from 1c9229e to e1e74d6 Compare April 12, 2024 06:03
@NathanFlurry NathanFlurry force-pushed the 04-10-fix_remove_erronious_dep_on_linode_cloudflare_tokens branch from 2e57e30 to 977c1ba Compare April 12, 2024 06:03
NathanFlurry added a commit that referenced this pull request Apr 12, 2024
## Motivation

Most people test the OSS repo locally. By defaulting to the public IP, the Terraform cluster fails to finish booting because it can't be accessed.

We'll provide better docs on the config after our OSS refresh.
@NathanFlurry NathanFlurry force-pushed the 04-10-chore_replace_auto-generate_public_ip_with_127.0.0.1 branch from e1e74d6 to 05120e0 Compare April 12, 2024 06:04
@NathanFlurry NathanFlurry force-pushed the 04-10-fix_remove_erronious_dep_on_linode_cloudflare_tokens branch from 977c1ba to 259abd8 Compare April 12, 2024 06:10
NathanFlurry added a commit that referenced this pull request Apr 12, 2024
## Motivation

Most people test the OSS repo locally. By defaulting to the public IP, the Terraform cluster fails to finish booting because it can't be accessed.

We'll provide better docs on the config after our OSS refresh.
@NathanFlurry NathanFlurry force-pushed the 04-10-chore_replace_auto-generate_public_ip_with_127.0.0.1 branch from 05120e0 to 725d5bc Compare April 12, 2024 06:11
@NathanFlurry NathanFlurry changed the base branch from 04-10-fix_remove_erronious_dep_on_linode_cloudflare_tokens to main April 12, 2024 06:40
NathanFlurry added a commit that referenced this pull request Apr 12, 2024
## Motivation

Most people test the OSS repo locally. By defaulting to the public IP, the Terraform cluster fails to finish booting because it can't be accessed.

We'll provide better docs on the config after our OSS refresh.
@NathanFlurry NathanFlurry force-pushed the 04-10-chore_replace_auto-generate_public_ip_with_127.0.0.1 branch 2 times, most recently from 37b6bda to 725d5bc Compare April 12, 2024 06:44
## Motivation

Most people test the OSS repo locally. By defaulting to the public IP, the Terraform cluster fails to finish booting because it can't be accessed.

We'll provide better docs on the config after our OSS refresh.
@NathanFlurry NathanFlurry force-pushed the 04-10-chore_replace_auto-generate_public_ip_with_127.0.0.1 branch from 725d5bc to 21d2ad1 Compare April 12, 2024 06:56
@graphite-app graphite-app bot merged commit 21d2ad1 into main Apr 12, 2024
9 of 10 checks passed
@graphite-app graphite-app bot deleted the 04-10-chore_replace_auto-generate_public_ip_with_127.0.0.1 branch April 12, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant