Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add workflows #783

Merged
merged 1 commit into from
Jun 5, 2024
Merged

feat: add workflows #783

merged 1 commit into from
Jun 5, 2024

Conversation

MasterPtato
Copy link
Contributor

Changes

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented May 9, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented May 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on Graphite Graphite

This was referenced May 9, 2024
Merged
Merged
Merged
@MasterPtato MasterPtato force-pushed the 05-07-fix_remove_trace_from_ops branch from f3e2823 to ebaa8ad Compare May 9, 2024 01:01
@MasterPtato MasterPtato force-pushed the 05-07-fix_remove_trace_from_ops branch from ebaa8ad to 6c8b08b Compare May 9, 2024 21:25
@MasterPtato MasterPtato mentioned this pull request May 9, 2024
Merged
AngelOnFira
AngelOnFira reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to the top of the stack to continue the review, these items might not be relevant up there.

docs/libraries/workflow/GLOSSARY.md Show resolved Hide resolved
docs/libraries/workflow/GLOSSARY.md Show resolved Hide resolved
docs/libraries/workflow/GLOSSARY.md Show resolved Hide resolved
docs/libraries/workflow/GLOSSARY.md Show resolved Hide resolved
This was referenced May 9, 2024
Merged
Merged
NathanFlurry
NathanFlurry requested changes May 15, 2024
View reviewed changes
docs/libraries/workflow/GLOSSARY.md Show resolved Hide resolved
docs/libraries/workflow/GLOSSARY.md Show resolved Hide resolved
docs/libraries/workflow/GLOSSARY.md Show resolved Hide resolved
docs/libraries/workflow/GLOSSARY.md Show resolved Hide resolved
docs/libraries/workflow/WORKFLOW.md Show resolved Hide resolved
lib/chirp-workflow/core/src/util.rs Show resolved Hide resolved
lib/chirp-workflow/core/src/util.rs Outdated Show resolved Hide resolved
lib/chirp-workflow/core/src/ctx/workflow.rs Outdated Show resolved Hide resolved
lib/chirp-workflow/core/src/worker.rs Show resolved Hide resolved
lib/chirp-workflow/core/src/worker.rs Show resolved Hide resolved
NathanFlurry
NathanFlurry reviewed May 15, 2024
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just tiny things, looking solid

@MasterPtato MasterPtato force-pushed the 05-07-fix_remove_trace_from_ops branch from 6c8b08b to d4b80f6 Compare May 16, 2024 22:25
@MasterPtato MasterPtato changed the base branch from 05-07-fix_remove_trace_from_ops to main May 16, 2024 22:30
@MasterPtato MasterPtato force-pushed the 05-08-feat_add_workflows branch 3 times, most recently from f23a951 to c6fb1f3 Compare May 17, 2024 00:38
@MasterPtato MasterPtato mentioned this pull request Jun 4, 2024
Merged
@MasterPtato MasterPtato mentioned this pull request Jun 5, 2024
Merged
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jun 5, 2024 •
edited
Loading

Merge activity

@MasterPtato
feat: add workflows (#783)
378d528 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot merged commit 378d528 into main Jun 5, 2024
7 of 10 checks passed
@graphite-app graphite-app bot deleted the 05-08-feat_add_workflows branch June 5, 2024 20:21
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

@AngelOnFira AngelOnFira Awaiting requested review from AngelOnFira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MasterPtato @NathanFlurry @AngelOnFira