Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple sequences in the input reference FASTA file #69

Closed
BertBog opened this issue Jun 29, 2023 · 4 comments · Fixed by #71
Closed

Support for multiple sequences in the input reference FASTA file #69

BertBog opened this issue Jun 29, 2023 · 4 comments · Fixed by #71
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BertBog
Copy link

BertBog commented Jun 29, 2023

Dear,

I have encountered an issue when I use AmpliGone for Influenza A datasets.
The input FASTA file contains 8 separate segments which results in the following error when I run AmpliGone (v1.2.1):
File "/usr/local/bin/lmod/AmpliGone/1.2.1/venv/lib/python3.9/site-packages/AmpliGone/AmpliGone.py", line 260, in main primer_df = TP_PrimerLists.result() File "/usr/lib/python3.9/concurrent/futures/_base.py", line 446, in result return self.__get_result() File "/usr/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result raise self._exception File "/usr/lib/python3.9/concurrent/futures/thread.py", line 58, in run result = self.fn(*self.args, **self.kwargs) File "/usr/local/bin/lmod/AmpliGone/1.2.1/venv/lib/python3.9/site-packages/AmpliGone/fasta2bed.py", line 69, in MakeCoordinateLists return pd.DataFrame( File "/usr/local/bin/lmod/AmpliGone/1.2.1/venv/lib/python3.9/site-packages/pandas/core/frame.py", line 774, in __init__ data = list(data) File "/usr/local/bin/lmod/AmpliGone/1.2.1/venv/lib/python3.9/site-packages/AmpliGone/fasta2bed.py", line 94, in CoordListGen ref_file = SeqIO.read(referencefile, "fasta") File "/usr/local/bin/lmod/AmpliGone/1.2.1/venv/lib/python3.9/site-packages/Bio/SeqIO/__init__.py", line 659, in read raise ValueError("More than one record found in handle") ValueError: More than one record found in handle

The command that I used:
ampligone --reference influenza_a-H3N2.fasta --primers primers.influenza_A.fasta --input sequences.fastq --output sequences_clipped.fastq --threads 4 --amplicon-type fragmented --error-rate 0.1

Would be it possible to resolve this issue?
I have obtained great results for SARS-CoV-2 with this tool.

Best regards,
Bert

@florianzwagemaker florianzwagemaker added enhancement New feature or request good first issue Good for newcomers labels Jul 6, 2023
@florianzwagemaker florianzwagemaker self-assigned this Jul 6, 2023
@florianzwagemaker
Copy link
Contributor

Dear Bert,

Thank you for your issue submission. Glad to hear our tool was useful for your SARS-CoV-2 analysis.

The issue that you're describing is a known problem with the current implementations of AmpliGone. I've added it to our backlog to have it solved in the next release (1.4.0) but i currently can't provide a time estimate for this.

We're currently working around this ourselves by simply processing all Influenza segments individually.
I do however think that processing all segments at once like you're describing is in-scope of this project and it will be added as soon as i can get to it.

I hope in the meantime you can still continue with your Influenza analyses regardless of this issue.

Best regards,
Florian

@florianzwagemaker florianzwagemaker linked a pull request Jul 27, 2023 that will close this issue
@florianzwagemaker
Copy link
Contributor

Just a quick update, multi-reference support is added in cd4f413

I'm still testing some things and making sure everything works as intended, but hopefully i can release this soon.

@florianzwagemaker
Copy link
Contributor

@BertBog This has now been released in version 1.3.0
This version can already be installed through pip with pip install AmpliGone==1.3.0
Installation through conda for this version should be available somewhere in the next 24 hours as we have to wait for the review/merge from the bioconda team.

If you come across any issues with this new feature please let us know and good luck with your Influenza analyses!

@BertBog
Copy link
Author

BertBog commented Aug 17, 2023

Thanks a lot for fixing this so quickly! I'll let you know if I experience any issues with the new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants