Skip to content

Commit

Permalink
Closes mozilla-mobile#1842: Whitelist AS profiler files.
Browse files Browse the repository at this point in the history
Given the conditions under which I've noticed these files are added, it's only
likely to occur in local builds. However, if we wanted to be extra safe that
these files aren't kept on disk in release builds, we could explicitly delete
them but then we'd presumably have to add a branch to allow developer builds to
use these files without problems. For simplicity, I've opted for the whitelist.
  • Loading branch information
mcomella authored and Riyaz Mohammed Ibrahim A committed Dec 14, 2017
1 parent e036f2e commit 75d4241
Showing 1 changed file with 13 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,19 @@ public class WebViewDataTest {
"app_dxmaker_cache",
"telemetry",
"databases",
"app_webview"
"app_webview",

// Android Studio will inject these files if you:
// - Build with Android Studio 3.0+
// - Have opened the "Android Profiler" tab at least once since the AS process started
// - Run on an API 26+ device (or maybe when explicitly enabling advanced debugging on older devices)
//
// This should only affect local builds and we don't want to risk breaking the profiler so
// we whitelist them. Additional details around when these files are added can be found in:
// https://github.com/mozilla-mobile/focus-android/issues/1842#issuecomment-348038392
"libperfa_x86.so",
"perfa.jar",
"perfd"
);

// We expect those folders to exist but they should be empty.
Expand Down

0 comments on commit 75d4241

Please sign in to comment.