-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to use Rizin API directly whenever appropriate #2666
Comments
First actionable items are:
|
This comment has been minimized.
This comment has been minimized.
Please note that in terms of minimum required work, we only really need to convert uses of commands that were converted to rzshell and where the oldshell handler was deleted. The others should still work. I'm working on this. |
It took too much time and now we have this left
|
Thank you, @imbillow, you did an amazing job, I never thought it's actually this big and often quite problematic. |
I think you missed the stuff in HexdumpWidget. |
Using API directly will improve the performance and allow to avoid situations when Rizin command has changed but it went unnoticed in Cutter. Using API will guarantee if the function has changed - it will break the compilation.
Here is the current situation (will be updated periodically):
The text was updated successfully, but these errors were encountered: