Convert to rizin APIs #2968
Merged
Convert to rizin APIs #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and `getConfigOptions`
XVilka
approved these changes
Jun 12, 2022
| @@ -4430,3 +4457,23 @@ QByteArray CutterCore::ioRead(RVA addr, int len) | |||
|
|
|||
| return array; | |||
| } | |||
|
|
|||
| QStringList CutterCore::getConfigVariableSpaces(const QString &key) | |||
There was a problem hiding this comment.
Eventually, we might want to provide this from the Rizin side of the API.
There was a problem hiding this comment.
It might be a separate PR.
There was a problem hiding this comment.
Yes, that's why I wrote "eventually".
wargio
reviewed
Jun 12, 2022
Co-authored-by: Giovanni <561184+wargio@users.noreply.github.com>
wargio
approved these changes
Jun 13, 2022
ret2libc
reviewed
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Convert:
esildrpahts.ar-wcraets-e <val>=?foAnd add
CutterCore.getConfigVariableSpacesCutterCore.getConfigOptionsTest plan (required)
Closing issues
Partially addresses #2666