Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert cmds {., afv[WR]j} #3017

Merged
merged 11 commits into from
Aug 14, 2022
Merged

Convert cmds {., afv[WR]j} #3017

merged 11 commits into from
Aug 14, 2022

Conversation

imbillow
Copy link
Contributor

@imbillow imbillow commented Aug 11, 2022

Your checklist for this pull request

Detailed description

Test plan (required)

Closing issues

Partially addresses
#2666

@imbillow imbillow changed the title Convert cmd . Convert cmds {., afv[WR]j} Aug 11, 2022
src/core/Cutter.cpp Outdated Show resolved Hide resolved
@imbillow
Copy link
Contributor Author

/home/runner/work/cutter/cutter/build/dist/rz-ghidra-prefix/src/rz-ghidra/src/RizinScope.cpp:10:10: fatal error: rz_build_version.h: No such file or directory
 #include <rz_build_version.h>
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

@karliss
Copy link
Member

karliss commented Aug 12, 2022

/home/runner/work/cutter/cutter/build/dist/rz-ghidra-prefix/src/rz-ghidra/src/RizinScope.cpp:10:10: fatal error: rz_build_version.h: No such file or directory
 #include <rz_build_version.h>
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

That's probably caused by rizinorg/rz-ghidra#294

@XVilka
Copy link
Member

XVilka commented Aug 13, 2022

@imbillow @karliss, just update Rizin to the latest commit, it should fix the problem.

@XVilka
Copy link
Member

XVilka commented Aug 13, 2022

@imbillow also Cutter seems need an update too:

/home/runner/work/cutter/cutter/src/dialogs/AboutDialog.cpp:1:10: fatal error: rz_version.h: No such file or directory
    1 | #include "rz_version.h"
      |          ^~~~~~~~~~~~~~

@karliss karliss merged commit 756850a into dev Aug 14, 2022
@XVilka XVilka deleted the convert_dot branch August 14, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants