Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the woodpecker config. #3365

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Remove the woodpecker config. #3365

merged 1 commit into from
Jul 27, 2024

Conversation

karliss
Copy link
Member

@karliss karliss commented Jul 26, 2024

At this point there is no need for it. macOS arm64 builds are now done on GHA. From what I remember it was only introduced, because at the first apple silicon devices were released GHA didn't provide any suitable runners.

Doing all the builds on same CI platform simplifies the maintenance.

Not sure if there is anything in woodpecker management panel which needs to be disabled, beside the config removal in cutter repo.

Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thestr4ng3r This means we can remove them in Rizin as well? Or is there something special about it?

@karliss karliss requested a review from thestr4ng3r July 27, 2024 07:30
Copy link
Member

@thestr4ng3r thestr4ng3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the build on GHA arm64 works, then no need to keep this indeed. The woodpecker was introduced only because no better solution was available in GHA at that time.

@karliss
Copy link
Member Author

karliss commented Jul 27, 2024

@thestr4ng3r What about my question on woodpecker side configuration? Does it simply monitor all repos in an organization, or is there anything which needs to be disabled in their config panel so that it doesn't complain about not being able to find any configs in repo like the appveyor did?

@thestr4ng3r
Copy link
Member

thestr4ng3r commented Jul 27, 2024

Does it simply monitor all repos in an organization

Repos are enabled manually in woodpecker. It does not monitor all repos in the org.

It might still register that commits are pushed and that there is no config in them. But I don't think this will break anything, it takes the config from the commit it is building, not a global URL or something.
We can remove the webhook and/or disable it on woodpecker side if we want to disable it indefinitely.

@karliss
Copy link
Member Author

karliss commented Jul 27, 2024

Thanks for clarifying. As long as it doesn't complain or add any misleading messages to the commits I am fine with it.

@karliss karliss merged commit 27f5cc3 into rizinorg:dev Jul 27, 2024
11 checks passed
@karliss karliss deleted the woodpecker branch July 27, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants