Add N_THREAD_LIMIT to limit the max number of threads (upper limit). #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wargio
requested review from
ret2libc,
thestr4ng3r,
XVilka and
kazarmy
as code owners
wargio
force-pushed
the
fuzz-dist-set-threads-limit
branch
from
ec4003f
to
ff9530e
Compare
wargio
force-pushed
the
fuzz-dist-set-threads-limit
branch
from
ff9530e
to
c15c298
Compare
XVilka
approved these changes
May 23, 2024
| @@ -7,6 +7,7 @@ option('blob', type: 'boolean', value: false, description: 'Compile just one bin | |||
| option('subprojects_check', type: 'boolean', value: true, description: 'Check if git subprojects are up-to-date. Might be useful to disable this when developing on a different subproject version') | |||
| option('portable', type: 'boolean', value: false, description: 'Make rizin installation moveable, by using relative paths instead of absolute ones') | |||
| option('extra_prefix', type: 'string', value: '', description: 'Extra load path prefix (absolute path) for plugins, sdb, sigdb, etc.') | |||
| option('n_thread_limit', type: 'integer', min: 1, value: 32767) | |||
There was a problem hiding this comment.
Why so big? Could have been less, I think.
There was a problem hiding this comment.
because on linux is high. on windows is low. also there are many servers using arm having 1k cores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This PR allows to create more threads than (previously) allowed, but also sets an hardcoded upper limit (that can be changed as a meson option)