-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #4506 #4519
Revert #4506 #4519
Conversation
Updated the pr description. |
The macos CI is not broken. never worked properly. it pops up the UI asking for admin password and locks there. i tested this on osx 12 on x64 machine. |
What the hell. i reverted previously and still had the same issue, and on yours works instead. |
Gimme this week and i will fix this. |
i don't have an x86 mac, and i see that woodpecker runs its debug tests just fine (with an occasional error now and then) so ok and good luck! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a temporary solution
Your checklist for this pull request
Detailed description
@wargio did a fine job with #4506 but unfortunately it broke the macos CI build and therefore this pr proposes that #4506 (and the associated pr #4510) be reverted for now until its kinks are ironed out.
Test plan
All builds are green.
Closing issues
...