Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #4506 #4519

Merged
merged 4 commits into from
May 27, 2024
Merged

Revert #4506 #4519

merged 4 commits into from
May 27, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented May 27, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

@wargio did a fine job with #4506 but unfortunately it broke the macos CI build and therefore this pr proposes that #4506 (and the associated pr #4510) be reverted for now until its kinks are ironed out.

Test plan

All builds are green.

Closing issues

...

@kazarmy
Copy link
Member Author

kazarmy commented May 27, 2024

Updated the pr description.

@wargio
Copy link
Member

wargio commented May 27, 2024

The macos CI is not broken. never worked properly. it pops up the UI asking for admin password and locks there. i tested this on osx 12 on x64 machine.

@wargio
Copy link
Member

wargio commented May 27, 2024

#4516

@wargio
Copy link
Member

wargio commented May 27, 2024

What the hell. i reverted previously and still had the same issue, and on yours works instead.

@wargio
Copy link
Member

wargio commented May 27, 2024

Gimme this week and i will fix this.

@kazarmy
Copy link
Member Author

kazarmy commented May 27, 2024

i don't have an x86 mac, and i see that woodpecker runs its debug tests just fine (with an occasional error now and then) so ok and good luck!

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temporary solution

@kazarmy kazarmy merged commit 7b91fb6 into dev May 27, 2024
45 of 47 checks passed
@kazarmy kazarmy deleted the revert-#4506 branch May 27, 2024 13:51
wargio added a commit that referenced this pull request May 28, 2024
This reverts commit 7b91fb6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants