Extracting types handling into RzType (librz/type)
#896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVilka
requested review from
kazarmy,
ret2libc,
thestr4ng3r and
wargio
as code owners
XVilka
commented
Mar 24, 2021
| @@ -1718,34 +1720,6 @@ RZ_API void rz_core_autocomplete(RZ_NULLABLE RzCore *core, RzLineCompletion *com | |||
| } | |||
| } | |||
| rz_list_free(vars); | |||
| } else if (!strncmp(buf->data, "t ", 2) || !strncmp(buf->data, "t- ", 3)) { | |||
There was a problem hiding this comment.
I removed that type and pf autocompletion code since we are switching to the newshell anyway.
XVilka
force-pushed
the
rztypes
branch
2 times, most recently
from
b8ad370
to
055b1a2
Compare
thestr4ng3r
reviewed
Mar 24, 2021
XVilka
force-pushed
the
rztypes
branch
13 times, most recently
from
44c9bdf
to
6aeb397
Compare
XVilka
force-pushed
the
rztypes
branch
3 times, most recently
from
bd687bb
to
e05ec1b
Compare
XVilka
force-pushed
the
rztypes
branch
7 times, most recently
from
e298517
to
45c1772
Compare
This comment has been minimized.
This comment has been minimized.
thestr4ng3r
reviewed
Apr 6, 2021
|
Dead declarations in /* type.c */
RZ_API void rz_analysis_remove_parsed_type(RzAnalysis *analysis, const char *name);
RZ_API void rz_analysis_save_parsed_type(RzAnalysis *analysis, const char *parsed); |
thestr4ng3r
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQUASH ME
Your checklist for this pull request
Detailed description
Extracting RzType as a separate module in
librz/typefrom various places like RzAnalysis and RzUtil.The only dependency is RzUtil. (It also has RzIOBind for printing formats)
I also moved type-related stuff from
librz/util/format.cintolibrz/type/format.cbut without proper refactoring (the old code is complete mess and will require a separate enormous effort to clean up, ignore that part)Apart from few places in
librz/core/ctypes.cthe direct access to the SDB with types information is removed.Test plan
All is green
Closing issues
Closes #369