use value class to improve StyledComponent constructor time #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while profiling that it was taking a significant amount of time to construct components on one of my projects with a very large dom.
by very large I mean
this improvement is achived by making the delegate for refreshOnUpdate a value class, and directly supplying the delegate when there is no initial value. therefore allowing for less class construction and storing of the delegate classes.
before:
after:
profiling was done on Chrome on my linux desktop.