Data::Section should use Sub::Exporter::ForMethods

[autarch]

See https://metacpan.org/pod/Data::Section#MooseX::Declare-and-namespace::autoclean for an explanation of why along with the workaround I'm currently using.

[karenetheridge]

That doesn't explain why you think the subs should always be installed as methods?

[autarch]

@karenetheridge - Because the Data::Section docs explicitly talk about "the methods exported by Data::Section". If they're intended to be used as methods then they should be installed as methods.

But amusingly, I didn't realize I'd linked to the Data::Section docs (I thought it was in MX::Declare).

[karenetheridge]

sounds like the docs should s/methods/subs/g then ;)

[autarch]

It's more than just that phrase. You need to read the docs, I think. They clearly show all uses of this module as being via method calls.

That said, I'd be fine if this was rewritten to actually be exported subs. I don't really like the "export methods" thing.

[autarch]

I'd actually note that with Moose we already have a perfectly good tool for exporting methods. It's called Moose::Role ;)

[rjbs]

The docs already point at ForMethods, and I think that's sufficient.

[karenetheridge]

After re-reading this issue, I think I'm inclined to agree with you - the subs are called as methods, therefore we don't want the subs ever to be cleaned, so it would be reasonable to always install as methods.