New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build_element
support to the ModuleBuild plugin.
#121
Conversation
To be fair, users can also work around this issue by creating a subclass that makes the necessary calls in its constructor, and just specify it in |
Why not put thoses files in share/ and use [ShareDir] ? |
I apologize for this patch languishing. I will apply it post haste if rebased. (I had a quick go at it, but it was not trivial.) |
I don't think it's a good idea for us to be supporting putting non-perl files into PERL5LIB. That's what a sharedir is for. |
Share dir does do this but at additional cognitive overhead. |
Rebased. |
@jberger what do you mean by this? |
@karenetheridge This is a feature of Module::Build. You may not want to encourage it, which I get, but then that should go into the Module::Build docs as a recommendation or something (and the EU::MM docs). Ideally, Dist::Zilla would pass through whatever the installer modules support. |
@Leont what do you think? Should we try to discourage this feature of Module::Build, or live with it? |
ShareDir still has the problem of the files being in a different place when you are in a git checkout or after installation. To use it people have to dream up heuristics to decide which scenario they are in. Allowing to install non perl files directly is useful in that you don't need these heuristics. |
Test::File::ShareDir works pretty well (although its guts need a lot of love.. different topic..) |
|
Thanks, applied! |
Oops, there's no documentation for this new option! |
This is so that, if you have non-Perl files in
lib
(.js
,.sql
,.jpg
, or whatever), you can tell Module::Build to install them.I did a bit of testing with MakeMaker, and it looks as if it installs whatever is in
lib
without having to be told.