-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encoding support #3
Conversation
1. now possible to pick an encoding via the "use" statement use M:L:R -readers => { encoding => ... } 2. default is "encoding(UTF-8)" 3. (read|write)_file now take options hashref and allow 'encoding'
Addresses #1 |
I have reviewed this and I think it is all good. I will try to merge it at once with a few other changes. |
As I reflect on @dolmen's original concern, perhaps the "encoding" option should be renamed "binmode" for clarity. (FWIW, that's the name I used for Path::Tiny.) Then people will get that ":raw" or ":utf8" or ":utf8_strict" or ":encoding(UTF-8)" are all legitimate. |
I prefer binmode also. I was going to suggest it once I saw your patch, but decided it wasn't worth worrying about. I'm glad somebody else mentioned it, because I like it better, too. |
👍 for |
This is now in a trial release. |
Doesn't this break 5.6 compatibility? The metadata should be updated to reflect that. Also, IO::String could be dumped in favor using PerlIO. |
I have added a prereq for 5.8.1 The IO::String, I'll look at doing a bit later, thanks. |
now possible to pick an encoding via the "use" statement
use M:L:R -readers => { encoding => ... }
default is "encoding(UTF-8)"
(read|write)_file now take options hashref and allow 'encoding'