defer wrapping leaves passed to all/any/none #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, leaves (plain strings and numbers) passed to
all/any/none were converted to "real tests" with Test::Deep::wrap
during the all/any/none test's initialization. This meant that
they were subject to the $LeafWrapper in place when any() was called,
rather than when the enclosing cmp_deeply was called. This meant that
leaves inside and outside of all/any/none were treated differently.
Here's a test, not suitable for inclusion, that demonstrated the
problem:
use strict;
use warnings;
use JSON;
use JSON::Typist;
use Test::Deep;
use Test::Deep::JType;
use Test::More;
my $json = q<{"foo":1}>;
my $data = JSON::Typist->new->apply_types(decode_json($json));
jcmp_deeply($data->{foo}, 1);
jcmp_deeply($data->{foo}, jnum(1));
jcmp_deeply($data->{foo}, any(jnum(1)));
jcmp_deeply($data->{foo}, any(1)); # <-- fails, 1 doesn't right wrapper
done_testing;
|
Seems legit. Are there any tests we can write to show the fix? |
|
I started on some but they didn't demonstrate the problem. I'll get back to them now-ish. |
This commit moves tests for $LeafWrapper from shallow.t to a new test file. It also adds tests for the bug caused by all/any/none wrapping their arguments at init time instead of at test time. Without the fix, the second set of tests fail because the $LeafWrapper in play for the calls to any and all is shallow() and not str().
|
I was close. Now I got it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, leaves (plain strings and numbers) passed to
all/any/none were converted to "real tests" with Test::Deep::wrap
during the all/any/none test's initialization. This meant that
they were subject to the $LeafWrapper in place when any() was called,
rather than when the enclosing cmp_deeply was called. This meant that
leaves inside and outside of all/any/none were treated differently.
Here's a test, not suitable for inclusion, that demonstrated the
problem: